This is an archive of the discontinued LLVM Phabricator instance.

Fix bug in affinity binding during team allocation.
ClosedPublic

Authored by jlpeyton on Jul 13 2015, 1:35 PM.

Reviewers

Summary

One line addition which re-binds threads to places (__kmp_partition_places()) in case the hot team size is reduced via omp_set_num_threads().

jlpeyton retitled this revision from to Fix bug in affinity binding during team allocation..

jlpeyton updated this object.

jlpeyton added a reviewer: hfinkel.

jlpeyton set the repository for this revision to rL LLVM.

ping

LGTM.

This revision is now accepted and ready to land.Aug 15 2015, 8:14 PM

Path

Size

runtime/

src/

3 lines

Show First 20 Lines • Show All 4,847 Lines • ▼ Show 20 Lines	#endif
__kmp_reinitialize_team( team, new_icvs, root->r.r_uber_thread->th.th_ident );		__kmp_reinitialize_team( team, new_icvs, root->r.r_uber_thread->th.th_ident );

KF_TRACE( 10, ("__kmp_allocate_team2: T#%d, this_thread=%p team=%p\n",		KF_TRACE( 10, ("__kmp_allocate_team2: T#%d, this_thread=%p team=%p\n",
0, team->t.t_threads[0], team ) );		0, team->t.t_threads[0], team ) );
__kmp_push_current_task_to_thread( team->t.t_threads[ 0 ], team, 0 );		__kmp_push_current_task_to_thread( team->t.t_threads[ 0 ], team, 0 );

#if OMP_40_ENABLED		#if OMP_40_ENABLED
# if KMP_AFFINITY_SUPPORTED		# if KMP_AFFINITY_SUPPORTED
if ( team->t.t_proc_bind == new_proc_bind ) {		if ( ( team->t.t_size_changed == 0 )
		&& ( team->t.t_proc_bind == new_proc_bind ) ) {
KA_TRACE( 200, ("__kmp_allocate_team: reusing hot team #%d bindings: proc_bind = %d, partition = [%d,%d]\n",		KA_TRACE( 200, ("__kmp_allocate_team: reusing hot team #%d bindings: proc_bind = %d, partition = [%d,%d]\n",
team->t.t_id, new_proc_bind, team->t.t_first_place,		team->t.t_id, new_proc_bind, team->t.t_first_place,
team->t.t_last_place ) );		team->t.t_last_place ) );
}		}
else {		else {
team->t.t_proc_bind = new_proc_bind;		team->t.t_proc_bind = new_proc_bind;
__kmp_partition_places( team );		__kmp_partition_places( team );
}		}
▲ Show 20 Lines • Show All 2,811 Lines • Show Last 20 Lines