This required adding the instruction predicate HasMips32r5.
Details
Diff Detail
- Repository
- rL LLVM
Event Timeline
We can re-use the classes ER_FM and ER_FT for the definition of the ERETNC instruction.
Also, I believe that we should use (or create) invalid-mips32r5.s in order to test errors for pre-R5 ISAs. Please. wait for Daniel's response on that.
lib/Target/Mips/MipsInstrFormats.td | ||
---|---|---|
656–664 ↗ | (On Diff #29545) | We can re-use the ER_FM format above by adding a boolean parameter that sets the 6th bit. |
lib/Target/Mips/MipsInstrInfo.td | ||
880–884 ↗ | (On Diff #29545) | We can just use ER_FT for the ERETNC definition since the classes are identical. |
test/MC/Mips/mips32/valid-xfail.s | ||
38 ↗ | (On Diff #29545) | @dsanders: I believe that we should place this test in invalid-mips32r5.s for pre-R5 ISAs, right? |
Thanks for reviewing this.
test/MC/Mips/mips32/valid-xfail.s | ||
---|---|---|
38 ↗ | (On Diff #29545) | Not quite. $isa/valid-xfail.s is for instructions that should be valid on $isa but currently xfail. $isa1/invalid-$isa2.s is for instructions that are valid on $isa1 and invalid on $isa2. This is valid on MIPS32r5 and invalid on MIPS32 so it belongs in mips32r5/invalid-mips32{,r2,r3}.s |