This is an archive of the discontinued LLVM Phabricator instance.

Differential D11128

[CMake] Add missing DebugInfo libraries to llvm-shlib
ClosedPublic

Authored by loladiro on Jul 12 2015, 7:24 PM.

Details

Reviewers
beanz
Commits
rG7ddd501b7149: [CMake] Add missing DebugInfo libraries to llvm-shlib
rL242054: [CMake] Add missing DebugInfo libraries to llvm-shlib

Diff Detail

Repository
rL LLVM

Event Timeline

loladiro updated this revision to Diff 29526.Jul 12 2015, 7:24 PM
loladiro retitled this revision from to [CMake] Add missing DebugInfo libraries to llvm-shlib.
loladiro updated this object.
loladiro added a reviewer: beanz.
loladiro set the repository for this revision to rL LLVM.
loladiro added a subscriber: llvm-commits.
beanz accepted this revision.Jul 13 2015, 12:37 PM
beanz edited edge metadata.

LGTM.

This revision is now accepted and ready to land.Jul 13 2015, 12:37 PM
Closed by commit rL242054: [CMake] Add missing DebugInfo libraries to llvm-shlib (authored by kfischer). · Explain WhyJul 13 2015, 12:42 PM
This revision was automatically updated to reflect the committed changes.
loladiro added a comment.Jul 14 2015, 8:36 PM

This is also missing Option and LibDriver. However, even after that's added there's still a few functions that the Makefile version exports that the CMake one does not, e.g. ConvertUTF8toUTF32. Though admittedly the best solution might just be to move those into the llvm namespace.

Revision Contents

PathSize
llvm/
trunk/
tools/
llvm-shlib/
2 lines

Diff 29596

llvm/trunk/tools/llvm-shlib/CMakeLists.txt

Show All 9 Lines
if(NOT DEFINED LLVM_DYLIB_COMPONENTS) if(NOT DEFINED LLVM_DYLIB_COMPONENTS)
set(LLVM_DYLIB_COMPONENTS set(LLVM_DYLIB_COMPONENTS
${LLVM_TARGETS_TO_BUILD} ${LLVM_TARGETS_TO_BUILD}
Analysis Analysis
BitReader BitReader
BitWriter BitWriter
CodeGen CodeGen
Core Core
DebugInfoDWARF
DebugInfoPDB
ExecutionEngine ExecutionEngine
IPA IPA
IPO IPO
IRReader IRReader
InstCombine InstCombine
Instrumentation Instrumentation
Interpreter Interpreter
Linker Linker
▲ Show 20 Lines • Show All 90 Lines • Show Last 20 Lines