This is an archive of the discontinued LLVM Phabricator instance.

WebAssembly: add placeholder intrinsics header
ClosedPublic

Authored by jfb on Jul 9 2015, 1:04 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

jfb updated this revision to Diff 29377.Jul 9 2015, 1:04 PM
jfb retitled this revision from to WebAssembly: add placeholder intrinsics header.
jfb updated this object.
jfb added a reviewer: sunfish.
jfb added a subscriber: llvm-commits.
sunfish accepted this revision.Jul 9 2015, 1:47 PM
sunfish edited edge metadata.
sunfish added inline comments.
include/llvm/IR/IntrinsicsWebAssembly.td
10 ↗(On Diff #29377)

Triple-slash comments, \file, and \brief? I know no other targets do that, but we could start a new trend :-).

14 ↗(On Diff #29377)

Other targets have a comment like this:

// All intrinsics start with "llvm.wasm.".

which is nice.

This revision is now accepted and ready to land.Jul 9 2015, 1:47 PM
jfb updated this revision to Diff 29385.Jul 9 2015, 1:55 PM
jfb edited edge metadata.
  • Address sunfish's comments.
This revision was automatically updated to reflect the committed changes.
jfb marked 2 inline comments as done.Jul 9 2015, 1:58 PM