This is an archive of the discontinued LLVM Phabricator instance.

Differential D10976

Fix APFloat construction from 16 byte APInt.
ClosedPublic

Authored by chaoren on Jul 6 2015, 3:18 PM.

Details

Reviewers
clayborg
Commits
rG57fca019e4a6: Fix APFloat construction from 16 byte APInt.
rLLDB241606: Fix APFloat construction from 16 byte APInt.
rL241606: Fix APFloat construction from 16 byte APInt.

Diff Detail

Repository
rL LLVM

Event Timeline

chaoren updated this revision to Diff 29131.Jul 6 2015, 3:18 PM
chaoren retitled this revision from to Fix APFloat construction from 16 byte APInt..
chaoren updated this object.
chaoren added a reviewer: clayborg.
chaoren added a subscriber: lldb-commits.
clayborg accepted this revision.Jul 6 2015, 3:53 PM
clayborg edited edge metadata.

Looks good.

This revision is now accepted and ready to land.Jul 6 2015, 3:53 PM
Closed by commit rL241606: Fix APFloat construction from 16 byte APInt. (authored by chaoren). · Explain WhyJul 7 2015, 10:39 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lldb/
trunk/
source/
Core/
26 lines

Diff 29192

lldb/trunk/source/Core/DataExtractor.cpp

Show First 20 Lines • Show All 1,824 Lines • ▼ Show 20 Lines for (uint32_t count = 0; ValidOffset(offset) && count < item_count; ++count)
if (GetAPInt (*this, &offset, item_byte_size, apint)) if (GetAPInt (*this, &offset, item_byte_size, apint))
{ {
llvm::APFloat apfloat (ast->getFloatTypeSemantics(ast->DoubleTy), apint); llvm::APFloat apfloat (ast->getFloatTypeSemantics(ast->DoubleTy), apint);
apfloat.toString(sv, format_precision, format_max_padding); apfloat.toString(sv, format_precision, format_max_padding);
} }
} }
else if (item_bit_size == ast->getTypeSize(ast->LongDoubleTy)) else if (item_bit_size == ast->getTypeSize(ast->LongDoubleTy))
{ {
llvm::APInt apint; auto byte_size = item_byte_size;
switch (target_sp->GetArchitecture().GetMachine()) const auto &semantics = ast->getFloatTypeSemantics(ast->LongDoubleTy);
{ if (&semantics == &llvm::APFloat::x87DoubleExtended)
case llvm::Triple::x86: byte_size = 10;
case llvm::Triple::x86_64:
// clang will assert when constructing the apfloat if we use a 16 byte integer value
if (GetAPInt (*this, &offset, 10, apint))
{
llvm::APFloat apfloat (ast->getFloatTypeSemantics(ast->LongDoubleTy), apint);
apfloat.toString(sv, format_precision, format_max_padding);
}
break;
default: llvm::APInt apint;
if (GetAPInt (*this, &offset, item_byte_size, apint)) if (GetAPInt(*this, &offset, byte_size, apint))
{ {
llvm::APFloat apfloat (ast->getFloatTypeSemantics(ast->LongDoubleTy), apint); llvm::APFloat apfloat(semantics, apint);
apfloat.toString(sv, format_precision, format_max_padding); apfloat.toString(sv, format_precision, format_max_padding);
} }
break;
}
} }
else if (item_bit_size == ast->getTypeSize(ast->HalfTy)) else if (item_bit_size == ast->getTypeSize(ast->HalfTy))
{ {
llvm::APInt apint(item_bit_size, this->GetU16(&offset)); llvm::APInt apint(item_bit_size, this->GetU16(&offset));
llvm::APFloat apfloat (ast->getFloatTypeSemantics(ast->HalfTy), apint); llvm::APFloat apfloat (ast->getFloatTypeSemantics(ast->HalfTy), apint);
apfloat.toString(sv, format_precision, format_max_padding); apfloat.toString(sv, format_precision, format_max_padding);
} }
▲ Show 20 Lines • Show All 403 Lines • Show Last 20 Lines