Use string::find(char) for single character strings.

[brucem]

Summary

Use string::find(char) for single character strings.

[ki.stfu]

Lgtm

lldb/trunk/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp

ObjectFileELF::GetSegmentDataByIndex(lldb::user_id_t id)
     if (segment_header == NULL)
         return DataExtractor();
     return DataExtractor(m_data, segment_header->p_offset, segment_header->p_filesz);
 }
 
 std::string
 ObjectFileELF::StripLinkerSymbolAnnotations(llvm::StringRef symbol_name) const
 {
-    size_t pos = symbol_name.find("@");
+    size_t pos = symbol_name.find('@');
     return symbol_name.substr(0, pos).str();
 }
 
 //----------------------------------------------------------------------
 // ParseSectionHeaders
 //----------------------------------------------------------------------
 size_t
 ObjectFileELF::ParseSectionHeaders()

lldb/trunk/tools/lldb-mi/MICmdArgValOptionShort.cpp

 CMICmdArgValOptionShort::IsArgShortOption(const CMIUtilString &vrTxt) const
 {
     // Look for --someLongOption
     MIint nPos = vrTxt.find("--");
     if (nPos == 0)
         return false;
 
     // Look for -f short option
-    nPos = vrTxt.find("-");
+    nPos = vrTxt.find('-');
     if (nPos != 0)
         return false;
 
     if (vrTxt.length() > 2)
         return false;
 
     return true;
 }

lldb/trunk/tools/lldb-mi/MICmdArgValString.cpp

if (!m_bHandleDirPaths)
             return false;
     }
 
     // Look for --someLongOption, if found reject
     if (0 == vrTxt.find("--"))
         return false;
 
     // Look for -f type short options, if found reject
-    if ((0 == vrTxt.find("-")) && (vrTxt.length() == 2))
+    if ((0 == vrTxt.find('-')) && (vrTxt.length() == 2))
         return false;
 
     // Look for thread group i1 i2 i3...., if found reject
-    if ((vrTxt.find("i") == 0) && ::isdigit(vrTxt[1]))
+    if ((vrTxt.find('i') == 0) && ::isdigit(vrTxt[1]))
         return false;
 
     // Look for numbers, if found reject
     if (!m_bAcceptNumbers && vrTxt.IsNumber())
         return false;
 
     return true;
 }

lldb/trunk/tools/lldb-mi/MICmdCmdData.cpp

else if (m_lldbResult.GetOutputSize() > 0)
             const CMIUtilString strProperty(rLine.substr(nPropertyStartPos, nPropertyLen).c_str());
 
             // Skip all except LineEntry
             if (!CMIUtilString::Compare(strProperty, "LineEntry"))
                 continue;
 
             // LineEntry: \[0x0000000100000f37-0x0000000100000f45\): /path/to/file:3[:1]
             //              ^^^^^^^^^^^^^^^^^^ -- start address
-            const size_t nStartAddressStartPos = rLine.find("[");
-            const size_t nStartAddressEndPos = rLine.find("-");
+            const size_t nStartAddressStartPos = rLine.find('[');
+            const size_t nStartAddressEndPos = rLine.find('-');
             const size_t nStartAddressLen = nStartAddressEndPos - nStartAddressStartPos - 1;
             const CMIUtilString strStartAddress(rLine.substr(nStartAddressStartPos + 1, nStartAddressLen).c_str());
             const CMICmnMIValueConst miValueConst(strStartAddress);
             const CMICmnMIValueResult miValueResult("start", miValueConst);
             CMICmnMIResultRecord miRecordResult(m_cmdData.strMiCmdToken, CMICmnMIResultRecord::eResultClass_Done, miValueResult);
 
             // LineEntry: \[0x0000000100000f37-0x0000000100000f45\): /path/to/file:3[:1]
             //                                 ^^^^^^^^^^^^^^^^^^ -- end address
-            const size_t nEndAddressEndPos = rLine.find(")");
+            const size_t nEndAddressEndPos = rLine.find(')');
             const size_t nEndAddressLen = nEndAddressEndPos - nStartAddressEndPos - 1;
             const CMIUtilString strEndAddress(rLine.substr(nStartAddressEndPos + 1, nEndAddressLen).c_str());
             const CMICmnMIValueConst miValueConst2(strEndAddress);
             const CMICmnMIValueResult miValueResult2("end", miValueConst2);
             bool bOk = miRecordResult.Add(miValueResult2);
             if (!bOk)
                 return MIstatus::failure;
 

lldb/trunk/tools/lldb-mi/MICmdFactory.cpp

CMICmdFactory::IsValid(const CMIUtilString &vMiCmd) const
     bool bValid = true;
 
     if (vMiCmd.empty())
     {
         bValid = false;
         return false;
     }
 
-    const size_t nPos = vMiCmd.find(" ");
+    const size_t nPos = vMiCmd.find(' ');
     if (nPos != std::string::npos)
         bValid = false;
 
     return bValid;
 }
 
 //++ ------------------------------------------------------------------------------------
 // Details: Check a command is already registered.

lldb/trunk/tools/lldb-mi/MICmdInterpreter.cpp

 // Args:    vTextLine   - (R) Text data to interpret.
 // Return:  bool  - True = yes command token present, false = command not recognised.
 // Throws:  None.
 //--
 bool
 CMICmdInterpreter::MiHasCmdTokenEndingHyphen(const CMIUtilString &vTextLine)
 {
     // The hyphen is mandatory
-    const size_t nPos = vTextLine.find("-", 0);
+    const size_t nPos = vTextLine.find('-', 0);
     if ((nPos == std::string::npos))
         return false;
 
     if (MiHasCmdTokenPresent(vTextLine))
     {
         const std::string strNum = vTextLine.substr(0, nPos);
         if (!CMIUtilString(strNum.c_str()).IsNumber())
             return false;

 // Type:    Method.
 // Args:    vTextLine - (R) Text data to interpret.
 // Return:  bool  - True = yes command token present, false = token not present.
 // Throws:  None.
 //--
 bool
 CMICmdInterpreter::MiHasCmdTokenPresent(const CMIUtilString &vTextLine)
 {
-    const size_t nPos = vTextLine.find("-", 0);
+    const size_t nPos = vTextLine.find('-', 0);
     return (nPos > 0);
 }
 
 //++ ------------------------------------------------------------------------------------
 // Details: Does the command name entered match the criteria for a MI command format.
 //          Is a recognised command present? The command name is entered into the
 //          command meta data structure whether correct or not for reporting or later
 //          command execution purposes. Command options is present are also put into the
if (m_miCmdData.bMIOldStyle)
         while (::isdigit(cChar) != 0)
         {
             cChar = vTextLine[++i];
         }
         nPos = --i;
     }
     else
     {
-        nPos = vTextLine.find("-", 0);
+        nPos = vTextLine.find('-', 0);
     }
 
     bool bFoundCmd = false;
     const size_t nLen = vTextLine.length();
-    const size_t nPos2 = vTextLine.find(" ", nPos);
+    const size_t nPos2 = vTextLine.find(' ', nPos);
     if (nPos2 != std::string::npos)
     {
         if (nPos2 == nLen)
             return false;
         const CMIUtilString cmd = CMIUtilString(vTextLine.substr(nPos + 1, nPos2 - nPos - 1).c_str());
         if (cmd.empty())
             return false;