Remove unnecessary members from MICmdArgContext.

[brucem]

Summary

Remove unnecessary members from MICmdArgContext.

We don't need constants for these value stored in every instance
of the class.

lldb/trunk/tools/lldb-mi/MICmdArgContext.h

public:
     // Overridden:
   public:
     // From CMIUtilString
     /* dtor */ virtual ~CMICmdArgContext(void);
 
     // Attributes:
   private:
     CMIUtilString m_strCmdArgsAndOptions;
-    const char m_constCharSpace;
-    const CMIUtilString m_constStrSpace;
 };

lldb/trunk/tools/lldb-mi/MICmdArgContext.cpp

 //++ ------------------------------------------------------------------------------------
 // Details: CMICmdArgContext constructor.
 // Type:    Method.
 // Args:    None.
 // Return:  None.
 // Throws:  None.
 //--
 CMICmdArgContext::CMICmdArgContext(void)
-    : m_constCharSpace(' ')
-    , m_constStrSpace(" ")
 {
 }
 
 //++ ------------------------------------------------------------------------------------
 // Details: CMICmdArgContext constructor.
 // Type:    Method.
 // Args:    vrCmdLineArgsRaw    - (R) The text description of the arguments options.
 // Return:  None.
 // Throws:  None.
 //--
 CMICmdArgContext::CMICmdArgContext(const CMIUtilString &vrCmdLineArgsRaw)
     : m_strCmdArgsAndOptions(vrCmdLineArgsRaw)
-    , m_constCharSpace(' ')
-    , m_constStrSpace(" ")
 {
 }
 
 //++ ------------------------------------------------------------------------------------
 // Details: CMICmdArgContext destructor.
 // Type:    Method.
 // Args:    None.
 // Return:  None.
CMICmdArgContext::RemoveArg(const CMIUtilString &vArg)
     while (1)
     {
         if (nPos == (MIint)std::string::npos)
             return MIstatus::success;
 
         bool bPass1 = false;
         if (nPos != 0)
         {
-            if (m_strCmdArgsAndOptions[nPos - 1] == m_constCharSpace)
+            if (m_strCmdArgsAndOptions[nPos - 1] == ' ')
                 bPass1 = true;
         }
         else
             bPass1 = true;
 
         const MIuint nEnd = nPos + nLen;
 
         if (bPass1)
         {
             bool bPass2 = false;
             if (nEnd < nLenCntxt)
             {
-                if (m_strCmdArgsAndOptions[nEnd] == m_constCharSpace)
+                if (m_strCmdArgsAndOptions[nEnd] == ' ')
                 {
                     bPass2 = true;
                     nExtraSpace = 1;
                 }
             }
             else
                 bPass2 = true;
 
CMICmdArgContext::RemoveArgAtPos(const CMIUtilString &vArg, const MIuint nArgIndex)
     while (it != itEnd)
     {
         const CMIUtilString &rWord(*it);
         if (nWordIndex++ != nArgIndex)
         {
             // Single words
             strBuildContextUp += rWord;
             if (bSpaceRequired)
-                strBuildContextUp += m_constStrSpace;
+                strBuildContextUp += " ";
         }
         else
         {
             // If quoted loose quoted text
             if (++it != itEnd)
             {
                 CMIUtilString words = rWord;
                 while (vArg != words)
                 {
                     if (bSpaceRequired)
-                        words += m_constStrSpace;
+                        words += " ";
                     words += *it;
                     if (++it == itEnd)
                         break;
                 }
                 if (it != itEnd)
                     --it;
             }
         }

 // Args:    None.
 // Return:  MIuint  - 0 to n arguments present.
 // Throws:  None.
 //--
 MIuint
 CMICmdArgContext::GetNumberArgsPresent(void) const
 {
     CMIUtilString::VecString_t vecOptions;
-    return m_strCmdArgsAndOptions.SplitConsiderQuotes(m_constStrSpace, vecOptions);
+    return m_strCmdArgsAndOptions.SplitConsiderQuotes(" ", vecOptions);
 }
 
 //++ ------------------------------------------------------------------------------------
 // Details: Retrieve all the arguments or options remaining in *this context.
 // Type:    Method.
 // Args:    None.
 // Return:  MIUtilString::VecString_t   - List of args remaining.
 // Throws:  None.
 //--
 CMIUtilString::VecString_t
 CMICmdArgContext::GetArgs(void) const
 {
     CMIUtilString::VecString_t vecOptions;
-    m_strCmdArgsAndOptions.SplitConsiderQuotes(m_constStrSpace, vecOptions);
+    m_strCmdArgsAndOptions.SplitConsiderQuotes(" ", vecOptions);
     return vecOptions;
 }
 
 //++ ------------------------------------------------------------------------------------
 // Details: Copy assignment operator.
 // Type:    Method.
 // Args:    vOther  - (R) The variable to copy from.
 // Return:  CMIUtilString & - this object.