Page MenuHomePhabricator

[LLDB][MIPS] Handle false positives for MIPS hardware watchpoints
AbandonedPublic

Authored by mohit.bhakkad on Jun 25 2015, 11:44 PM.

Details

Reviewers
clayborg
jingham

Diff Detail

Repository
rL LLVM

Event Timeline

mohit.bhakkad retitled this revision from to [LLDB][MIPS] Handle false positives for MIPS hardware watchpoints.
mohit.bhakkad updated this object.
mohit.bhakkad edited the test plan for this revision. (Show Details)
mohit.bhakkad added reviewers: clayborg, jingham.
mohit.bhakkad set the repository for this revision to rL LLVM.
mohit.bhakkad added subscribers: jaydeep, bhushan, slthakur and 3 others.
mohit.bhakkad added inline comments.Jun 26 2015, 4:50 AM
source/Target/StopInfo.cpp
840

Sorry, I missed else part here.
it will make m_should_stop = false

clayborg requested changes to this revision.Jun 26 2015, 10:57 AM
clayborg edited edge metadata.

Can we clean up the value in lldb-server prior to sending it up to the debugger so that the debugger doesn't have to worry about architecture specific bits in Watchpoint.cpp? That would be a better way to fix this.

source/Breakpoint/Watchpoint.cpp
158–172

Can this not be done anywhere before it gets to this point? Like maybe down in lldb-server when it is reporting the watchpoint hit? Then this can be done with "#if define(MIPS)" since lldb-server is compiled for each architecture natively.

source/Target/StopInfo.cpp
840

Add

else
{
    m_should_stop = false;
}
This revision now requires changes to proceed.Jun 26 2015, 10:57 AM