This is an archive of the discontinued LLVM Phabricator instance.

Differential D10613

[CMake] Treating LLVM_INCLUDE_TOOLS, which is a bool, as a string to change behaviors of the build is a dirty hack. We shouldn't do it.
ClosedPublic

Authored by beanz on Jun 22 2015, 1:39 PM.

Details

Reviewers
samsonov
chapuni
Commits
rG69533a5a85cc: [CMake] Treating LLVM_INCLUDE_TOOLS, which is a bool, as a string to change…
rL240344: [CMake] Treating LLVM_INCLUDE_TOOLS, which is a bool, as a string to change…
Summary

I don't think anyone is relying on this behavior for bootstrapping (because I don't think it works), but if you do need it, speak now or forever hold your peace.

Diff Detail

Repository
rL LLVM

Event Timeline

beanz updated this revision to Diff 28151.Jun 22 2015, 1:39 PM
beanz retitled this revision from to [CMake] Treating LLVM_INCLUDE_TOOLS, which is a bool, as a string to change behaviors of the build is a dirty hack. We shouldn't do it..
beanz updated this object.
beanz edited the test plan for this revision. (Show Details)
beanz added reviewers: chapuni, samsonov.
beanz added a subscriber: Unknown Object (MLST).
samsonov accepted this revision.Jun 22 2015, 2:54 PM
samsonov edited edge metadata.

I don't use it. Can't speak for everyone :)

This revision is now accepted and ready to land.Jun 22 2015, 2:54 PM
Closed by commit rL240344: [CMake] Treating LLVM_INCLUDE_TOOLS, which is a bool, as a string to change… (authored by cbieneman). · Explain WhyJun 22 2015, 3:02 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
trunk/
tools/
13 lines

Diff 28165

llvm/trunk/tools/CMakeLists.txt

Show First 20 Lines • Show All 69 Lines • ▼ Show 20 Lineselse()
ignore_llvm_tool_subdirectory(lto) ignore_llvm_tool_subdirectory(lto)
ignore_llvm_tool_subdirectory(llvm-lto) ignore_llvm_tool_subdirectory(llvm-lto)
endif() endif()
add_llvm_tool_subdirectory(gold) add_llvm_tool_subdirectory(gold)
add_llvm_external_project(clang) add_llvm_external_project(clang)
add_llvm_external_project(llgo) add_llvm_external_project(llgo)
if( NOT LLVM_INCLUDE_TOOLS STREQUAL "bootstrap-only" )
add_llvm_external_project(lld) add_llvm_external_project(lld)
add_llvm_external_project(lldb) add_llvm_external_project(lldb)
# Automatically add remaining sub-directories containing a 'CMakeLists.txt' # Automatically add remaining sub-directories containing a 'CMakeLists.txt'
# file as external projects. # file as external projects.
add_llvm_implicit_external_projects() add_llvm_implicit_external_projects()
endif()
set(LLVM_COMMON_DEPENDS ${LLVM_COMMON_DEPENDS} PARENT_SCOPE) set(LLVM_COMMON_DEPENDS ${LLVM_COMMON_DEPENDS} PARENT_SCOPE)