This is an archive of the discontinued LLVM Phabricator instance.

AVX512 : cvtusi2ss/d intrinsics
ClosedPublic

Authored by igorb on Jun 16 2015, 12:24 AM.

Details

Summary

Change builtin function name and signature ( add third parameter - rounding mode ).
Added tests for intrinsics.

Diff Detail

Repository
rL LLVM

Event Timeline

igorb updated this revision to Diff 27749.Jun 16 2015, 12:24 AM
igorb retitled this revision from to AVX512 : cvtusi2ss/d intrinsics .
igorb updated this object.
igorb edited the test plan for this revision. (Show Details)
igorb added reviewers: delena, AsafBadouh, eugenis.
igorb set the repository for this revision to rL LLVM.
igorb added a subscriber: Unknown Object (MLST).
delena edited edge metadata.Jun 16 2015, 1:07 AM

One small fix, LGTM

lib/Transforms/Instrumentation/MemorySanitizer.cpp
2026 ↗(On Diff #27749)

it should be const int. Please check it with cast:

assert (isa<ConstantSDNode>(I.getArgOperand(2)) && ..

AsafBadouh accepted this revision.Jun 16 2015, 1:27 AM
AsafBadouh edited edge metadata.

LGTM

This revision is now accepted and ready to land.Jun 16 2015, 1:27 AM
igorb updated this revision to Diff 27753.Jun 16 2015, 1:43 AM
igorb edited edge metadata.

new diff uploaded.
changes according to comments

eugenis edited edge metadata.Jun 16 2015, 9:37 AM

MemorySanitizer change LGTM

This revision was automatically updated to reflect the committed changes.