This is an archive of the discontinued LLVM Phabricator instance.

clang-format: Fix __attribute__ being treated as decl name.
ClosedPublic

Authored by strager on Jun 10 2015, 4:08 PM.

Details

Reviewers
djasper
Summary

__attribute__ was treated as the name of a function
definition, with the tokens in parentheses being the
parameter list. This formats incorrectly with
AlwaysBreakAfterDefinitionReturnType. Fix it by treating
__attribute__ like decltype.

Diff Detail

Event Timeline

strager updated this revision to Diff 27474.Jun 10 2015, 4:08 PM
strager retitled this revision from to clang-format: Fix __attribute__ being treated as decl name..
strager updated this object.
strager edited the test plan for this revision. (Show Details)
strager added a reviewer: djasper.
strager added subscribers: sas, abdulras, Unknown Object (MLST).
strager updated this revision to Diff 27601.Jun 12 2015, 2:33 PM
strager updated this object.

Fix commit message for Phabricator.

strager updated this revision to Diff 27603.Jun 12 2015, 2:38 PM

Try to fix binary test problem.

djasper accepted this revision.Jun 23 2015, 4:28 AM
djasper edited edge metadata.

Looks good. Thanks!

This revision is now accepted and ready to land.Jun 23 2015, 4:28 AM

Please merge for me.

strager updated this revision to Diff 28742.Jun 29 2015, 7:31 PM
strager edited edge metadata.

Rebase.

djasper closed this revision.Jul 6 2015, 4:31 AM

Submitted as r241439.