This is an archive of the discontinued LLVM Phabricator instance.

[CMake] Add warning for using compile and link pools on unsupported versions of CMake or non-ninja generators.
ClosedPublic

Authored by beanz on Jun 2 2015, 11:55 AM.

Details

Summary

I've gotten feedback from users on CMake 2.8 that the compile and link pool options were not working. This is expected so I'm adding a warning so we can report invalid configurations to users.

Diff Detail

Repository
rL LLVM

Event Timeline

beanz updated this revision to Diff 26996.Jun 2 2015, 11:55 AM
beanz retitled this revision from to [CMake] Add warning for using compile and link pools on unsupported versions of CMake or non-ninja generators..
beanz updated this object.
beanz edited the test plan for this revision. (Show Details)
beanz added a reviewer: eugenis.
beanz added a subscriber: Unknown Object (MLST).
eugenis accepted this revision.Jun 3 2015, 4:55 PM
eugenis edited edge metadata.

LGTM, thanks

This revision is now accepted and ready to land.Jun 3 2015, 4:55 PM
This revision was automatically updated to reflect the committed changes.