Fix OBJCOPY and AR for Android.

[chaoren]

Summary

Previously, OBJCOPY was empty because of the missing comma,
and ar was just ar.

[ovyalov]

LGTM

test/make/Makefile.rules

231 ↗

(On Diff #26940)

Do we need to setup LD here as well?

[chaoren]

test/make/Makefile.rules

231 ↗

(On Diff #26940)

I think the linker is just CC. We don't invoke LD directly.

lldb/trunk/test/make/Makefile.rules

ifneq (,$(findstring clang,$(CC)))
     LDFLAGS += -fuse-ld=lld
   endif
 endif
 
 #----------------------------------------------------------------------
 # Android specific options
 #----------------------------------------------------------------------
 ifeq "$(OS)" "Android"
-    objcopy_notdir = $(if $(findstring clang,$(1)), \
-                          $(subst clang,objcopy,$(1)), \
-                               $(if $(findstring gcc,$(1)), \
-                                    $(subst gcc,objcopy,$(1)), \
-                                    $(subst cc,objcopy,$(1))))))
-    objcopy = $(if $(findstring /,$(1)),$(join $(dir $(1)), $(call objcopy_notdir,$(notdir $(1)))),$(call objcopy_notdir,$(1)))
-
     LDFLAGS += -pie
-    OBJCOPY = $(call objcopy $(CC))
+    replace_with = $(if $(findstring clang,$(1)), \
+                        $(subst clang,$(2),$(1)), \
+                        $(if $(findstring gcc,$(1)), \
+                             $(subst gcc,$(2),$(1)), \
+                             $(subst cc,$(2),$(1))))
+    ifeq "$(notdir $(CC))" "$(CC)"
+        replace_cc_with = $(call replace_with,$(CC),$(1))
+    else
+        replace_cc_with = $(join $(dir $(CC)),$(call replace_with,$(notdir $(CC)),$(1)))
+    endif
+    OBJCOPY = $(call replace_cc_with,objcopy)
+    AR = $(call replace_cc_with,ar)
 endif
 
 #----------------------------------------------------------------------
 # C++ standard library options
 #----------------------------------------------------------------------
 ifeq (1,$(USE_LIBSTDCPP))
   # Clang requires an extra flag: -stdlib=libstdc++
   ifneq (,$(findstring clang,$(CC)))