This is an archive of the discontinued LLVM Phabricator instance.

Fix TestPaths.
ClosedPublic

Authored by chaoren on Jun 1 2015, 10:58 AM.

Download Raw Diff

Details

Reviewers

vharron
clayborg

Commits

rGb79863c2cc41: Fix TestPaths.
rLLDB238767: Fix TestPaths.
rL238767: Fix TestPaths.

Diff Detail

Repository: rL LLVM

Event Timeline

chaoren updated this revision to Diff 26912.Jun 1 2015, 10:58 AM

chaoren retitled this revision from to Fix TestPaths..

chaoren updated this object.

chaoren edited the test plan for this revision. (Show Details)

chaoren added reviewers: vharron, clayborg.

chaoren added a subscriber: Unknown Object (MLST).

Looks good.

This revision is now accepted and ready to land.Jun 1 2015, 11:06 AM

Closed by commit rL238767: Fix TestPaths. (authored by chaoren). · Explain WhyJun 1 2015, 11:08 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

lldb/

trunk/

source/

Host/

common/

HostInfoBase.cpp

4 lines

Diff 26913

lldb/trunk/source/Host/common/HostInfoBase.cpp

Show First 20 Lines • Show All 328 Lines • ▼ Show 20 Lines	HostInfoBase::ComputeProcessTempFileDirectory(FileSpec &file_spec)
std::string pid_str{std::to_string(Host::GetCurrentProcessID())};		std::string pid_str{std::to_string(Host::GetCurrentProcessID())};
temp_file_spec.AppendPathComponent(pid_str);		temp_file_spec.AppendPathComponent(pid_str);
if (!FileSystem::MakeDirectory(temp_file_spec, eFilePermissionsDirectoryDefault).Success())		if (!FileSystem::MakeDirectory(temp_file_spec, eFilePermissionsDirectoryDefault).Success())
return false;		return false;

// Make an atexit handler to clean up the process specify LLDB temp dir		// Make an atexit handler to clean up the process specify LLDB temp dir
// and all of its contents.		// and all of its contents.
::atexit(CleanupProcessSpecificLLDBTempDir);		::atexit(CleanupProcessSpecificLLDBTempDir);
file_spec = temp_file_spec;		file_spec.GetDirectory().SetCString(temp_file_spec.GetCString());
return true;		return true;
}		}

bool		bool
HostInfoBase::ComputeTempFileBaseDirectory(FileSpec &file_spec)		HostInfoBase::ComputeTempFileBaseDirectory(FileSpec &file_spec)
{		{
file_spec.Clear();		file_spec.Clear();

Show All 19 Lines	HostInfoBase::ComputeGlobalTempFileDirectory(FileSpec &file_spec)
FileSpec temp_file_spec;		FileSpec temp_file_spec;
if (!HostInfo::ComputeTempFileBaseDirectory(temp_file_spec))		if (!HostInfo::ComputeTempFileBaseDirectory(temp_file_spec))
return false;		return false;

temp_file_spec.AppendPathComponent("lldb");		temp_file_spec.AppendPathComponent("lldb");
if (!FileSystem::MakeDirectory(temp_file_spec, eFilePermissionsDirectoryDefault).Success())		if (!FileSystem::MakeDirectory(temp_file_spec, eFilePermissionsDirectoryDefault).Success())
return false;		return false;

file_spec = temp_file_spec;		file_spec.GetDirectory().SetCString(temp_file_spec.GetCString());
return true;		return true;
}		}

bool		bool
HostInfoBase::ComputeHeaderDirectory(FileSpec &file_spec)		HostInfoBase::ComputeHeaderDirectory(FileSpec &file_spec)
{		{
// TODO(zturner): Figure out how to compute the header directory for all platforms.		// TODO(zturner): Figure out how to compute the header directory for all platforms.
return false;		return false;
▲ Show 20 Lines • Show All 50 Lines • Show Last 20 Lines