This is an archive of the discontinued LLVM Phabricator instance.

Add '+' sign at the end of echo package
ClosedPublic

Authored by chying on May 28 2015, 5:59 PM.

Reviewers

Commits

Summary

-Fix lldb test failures introduced by r238530
-This fix TestGdbRemoteAuxvSupport.py and TestLldbGdbServer.py

chying retitled this revision from to Add '+' sign at the end of echo package.

chying updated this object.

chying edited the test plan for this revision. (Show Details)

chying added a subscriber: Unknown Object (MLST).

chaoren edited edge metadata.

This revision is now accepted and ready to land.May 28 2015, 6:02 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

lldb/

trunk/

source/

Plugins/

Process/

gdb-remote/

2 lines

Show First 20 Lines • Show All 911 Lines • ▼ Show 20 Lines	GDBRemoteCommunicationServerCommon::Handle_qSupported (StringExtractorGDBRemote &packet)

// Features common to lldb-platform and llgs.		// Features common to lldb-platform and llgs.
uint32_t max_packet_size = 128 * 1024; // 128KBytes is a reasonable max packet size--debugger can always use less		uint32_t max_packet_size = 128 * 1024; // 128KBytes is a reasonable max packet size--debugger can always use less
response.Printf ("PacketSize=%x", max_packet_size);		response.Printf ("PacketSize=%x", max_packet_size);

response.PutCString (";QStartNoAckMode+");		response.PutCString (";QStartNoAckMode+");
response.PutCString (";QThreadSuffixSupported+");		response.PutCString (";QThreadSuffixSupported+");
response.PutCString (";QListThreadsInStopReply+");		response.PutCString (";QListThreadsInStopReply+");
response.PutCString (";qEcho");		response.PutCString (";qEcho+");
#if defined(__linux__)		#if defined(__linux__)
response.PutCString (";qXfer:auxv:read+");		response.PutCString (";qXfer:auxv:read+");
#endif		#endif

return SendPacketNoLock(response.GetData(), response.GetSize());		return SendPacketNoLock(response.GetData(), response.GetSize());
}		}

GDBRemoteCommunication::PacketResult		GDBRemoteCommunication::PacketResult
▲ Show 20 Lines • Show All 409 Lines • Show Last 20 Lines