This is an archive of the discontinued LLVM Phabricator instance.

[CMake] Bug 23468 - LLVM_OPTIMIZED_TABLEGEN does not work with Visual Studio
ClosedPublic

Authored by beanz on May 28 2015, 1:35 PM.

Details

Summary

Multi-configuration builds put their binaries into ${CMAKE_BINARY_DIR}/Release/bin/. The table-gen cross-compilation support needs to take that into account.

Diff Detail

Repository
rL LLVM

Event Timeline

beanz updated this revision to Diff 26728.May 28 2015, 1:35 PM
beanz retitled this revision from to [CMake] Bug 23468 - LLVM_OPTIMIZED_TABLEGEN does not work with Visual Studio.
beanz updated this object.
beanz edited the test plan for this revision. (Show Details)
beanz added a reviewer: yaron.keren.
beanz added a subscriber: Unknown Object (MLST).
beanz added a comment.May 28 2015, 1:43 PM

I also feel I should add that I've tested this against Xcode, so it does work in principal. I haven't tested it against Visual Studio because I'm on Darwin.

yaron.keren accepted this revision.May 28 2015, 2:24 PM
yaron.keren edited edge metadata.

This works well with Visual C++ 2013, LGTM.
Thanks for fixing this!

This revision is now accepted and ready to land.May 28 2015, 2:24 PM
This revision was automatically updated to reflect the committed changes.