Change Details

This reverts the behavior introduced by D43571. D43571 was a code cleanup patch that introduced early removing of section commands. It introduced the behavior change: LLD started emitting empty sections that are explicitly assigned to a segment. This behavior is not clean and we might produce empty sections in cases when we could be more aggressive in removing them. The problem here is that we should somehow preserve the information about segment assigned to n empty section before we remove it from the list. This patch adds an early phdrs propagation step, which is similar to one that we do after sorting orphan sections step.

This reverts a side effect introduced in the code cleanup patch D43571: LLD started to emit empty output sections that are explicitly assigned to a segment. This patch fixes the issue by removing the !sec.phdrs.empty() special case from isDiscardable. As compensation, we add an early phdrs propagation step (see the inline comment). This is similar to one that we do in adjustSectionsAfterSorting.

This reverts the behavior introduced bya side effect introduced in the code cleanup patch D43571.: D43571 was a code cleanup patch that introduced early removing of section commands. It introduced the behavior change: LLD started emitting empty sections that LLD started to emit empty output sections that are explicitly assigned to a segment. This behavior is not clean and we might produce patch fixes the issue by removing the !sec.phdrs.empty sections in() special cases when we from could be more aggressive in removing them. The problem here is that we should somehow preserve the information about segment assigned to n empty section before we remove it from the list. This patch adds an early phdrs propagation stepisDiscardable. As compensation, which is similar to one thatwe add an early phdrs propagation step (see the inline comment). we do after sorting orphan sThis is similar to one that we do in adjustSections stepAfterSorting.