Change Details

Sharing the implementation with LLVMELFDumper causes us to emit invalid JSON by printing the error message in the JSON body. Future patches can implement the HashHistogram functionality if needed for each of the LLVM and JSON implementations

Previously, the GNUELFDumper was the only implementer for Hash Histograms. This patch moves the implementation for printHashHistogram and printGnuHashHistogram into the ELFDumper base class, and allows each derived class to specialize how it outputs that information. This change also prevents the JSONELFDumper from emitting invalid JSON, since the shared implementation in LLVMELFDumper no longer emits a warning message to the output stream.

SharingPreviously, the implementation with LLVMELFDumper causes us to emitGNUELFDumper was the only implementer for Hash Histograms. invalid JSON by printingThis patch moves the error message in the JSON body. Future patches canimplementation for printHashHistogram and implement the printGnuHashHistogram functionality if needed for each of the LLVM andinto the ELFDumper base class, and allows each JSON implementationsderived class to specialize how it outputs that information. This change also prevents the JSONELFDumper from emitting invalid JSON, since the shared implementation in LLVMELFDumper no longer emits a warning message to the output stream.