Change Details

Imported functions and variables get the visibility from the prevailing module. However, non-prevailing and prevailing definitions do not get the visibility from the most constraining visibility among all modules. This patch * adds visibility bits to GlobalValueSummary::GVFlags * (for ELF) computes the most constraining visibility among all definitions and propagates it to all definitions Protected/hidden can imply dso_local which can enable some optimizations (this is stronger than GVFlags::DSOLocal because the implied dso_local can be leveraged for ELF -shared while default visibility dso_local has to be cleared for ELF -shared). Note: the visibility from a declaration is not tracked, so if a declaration has the most constraining visibility, the result visibility may not be that one.

Imported functions and variable get the visibility from the module supplying the definition. However, non-imported definitions do not get the visibility from (ELF) the most constraining visibility among all modules (Mach-O) the visibility of the prevailing definition. This patch * adds visibility bits to GlobalValueSummary::GVFlags * computes the result visibility and propagates it to all definitions Protected/hidden can imply dso_local which can enable some optimizations (this is stronger than GVFlags::DSOLocal because the implied dso_local can be leveraged for ELF -shared while default visibility dso_local has to be cleared for ELF -shared). Note: we don't have summaries for declarations, so for ELF if a declaration has the most constraining visibility, the result visibility may not be that one.

Imported functions and variables get the visibility from the prevailingmodule supplying the moduledefinition. However, non-prevailing and prevailing definitions do not getimported definitions do not get the visibility from the visibility from(ELF) the most constraining visibility among all modules (Mach-O) the visibility of the prevailing definition. This patch * adds visibility bits to GlobalValueSummary::GVFlags * (for ELF)* computes the most constrainingresult visibility among all definitions and propagates it to all definitions Protected/hidden can imply dso_local which can enable some optimizations (this is stronger than GVFlags::DSOLocal because the implied dso_local can be leveraged for ELF -shared while default visibility dso_local has to be cleared for ELF -shared). Note: the visibility from awe don't have summaries for declaration is not trackeds, so for ELF if a declaration has the most constraining visibility, the result visibility may not be that one.