Since now intrinsics can define what parameters are required to beEncode them directly as an imm argument to G_INTRINSIC*.
Since now intrinsics can now define what parameters are required to be
immediates, avoid using registers for them. Intrinsics could
potentially want a constant that isn't a legal register type. Also,
since G_CONSTANT is subject to CSE and legalization, transforms could
otentially obscure the value (and create extra work for the
selector). The register bank of a G_CONSTANT is also meaningful, so
this could throw off future folding and legalization logic for AMDGPU.
This will be much more convenient to work with than needing to call
getConstantVRegVal and checking if it may have failed for every
constant intrinsic parameter. AMDGPU has quite a lot of intrinsics wth
immarg operands, many of which need inspection during lowering. Having
to find the value in a register is going to add a lot of boilerplate
and waste compile time.
SelectionDAG has always provided TargetConstant for constants which
should not be legalized or materialized in a register. The distinction
between Constant and TargetConstant was somewhat fuzzy, and there was
no automatic way to force usage of TargetConstant for certain
intrinsic parameters. They were both ultimately ConstantSDNode, and it
was inconsistently used. It was quite easy to mis-select an
instruction requiring an immediate. For SelectionDAG, start emitting
TargetConstant for these arguments, and using timm to match them.
Most of the work here is to cleanup target handling of constants. Some
targets process intrinsics through intermediate custom nodes, which
need to preserve TargetConstant usage to match the intrinsic
expectation. Pattern inputs now need to distinguish whether a constant
is merely compatible with an operand or whether it is mandatory.
The GlobalISelEmitter needs to treat timm as a special case of a leaf
node, simlar to MachineBasicBlock operands. This should also enable
immediates, avoid using registers for them.handling of patterns for some G_* instructions with immediates, This will be morelike
convenient to work with, and avoids a few issues that SelectionDAGG_FENCE or G_EXTRACT.
dealt with by using TargetConstant
I haven't finished updating all of the targets yet. Intrinsics could potentially wantI handled X86
a constant that isn't a legal register type.first, Also,figuring it would be the worst to handle. since G_CONSTANT isMost of the remaining
subject to CSE and legalizationwork is for hexagon, transforms could potentially obscurebut SystemZ also needs a non-trivial change.
the value (and create extra work for the selector).
There is one crash remaining in GlobalISelEmitter when using timm for
a standalone Pat for an ARM intrinsic.