Change Details

Certain commands like 'memory write', 'register read' etc all use the OptionGroupFormat options but the help usage text for those options is not customized to those commands. One such example is: (lldb) help memory read -s <byte-size> ( --size <byte-size> ) The size in bytes to use when displaying with the selected format. (lldb) help memory write -s <byte-size> ( --size <byte-size> ) The size in bytes to use when displaying with the selected format. This patch allows such commands to overwrite the help text for the options in the OptionGroupFormat group as needed and fixes help text of memory write. Also, currently the 'memory write' command allows specifying the values when writing the file contents to memory but the values are actually ignored. This patch fixes that as well by erroring out when values are specified in such cases. llvm.org/pr49018.

Certain commands like 'memory write', 'register read' etc all use the OptionGroupFormat options but the help usage text for those options is not customized to those commands. One such example is: (lldb) help memory read -s <byte-size> ( --size <byte-size> ) The size in bytes to use when displaying with the selected format. (lldb) help memory write -s <byte-size> ( --size <byte-size> ) The size in bytes to use when displaying with the selected format. This patch allows such commands to overwrite the help text for the options in the OptionGroupFormat group as needed and fixes help text of memory write. Also, currently the 'memory write' command allows specifying the values when writing the file contents to memory but the values are actually ignored. This patch fixes that as well by erroring out when values are specified in such cases. llvm.org/pr49018.

Certain commands like 'memory write', 'register read' etc all use the OptionGroupFormat options but the help usage text for those options is not customized to those commands. One such example is: (lldb) help memory read -s <byte-size> ( --size <byte-size> ) The size in bytes to use when displaying with the selected format. (lldb) help memory write -s <byte-size> ( --size <byte-size> ) The size in bytes to use when displaying with the selected format. This patch allows such commands to overwrite the help text for the options in the OptionGroupFormat group as needed and fixes help text of memory write. Also, currently the 'memory write' command allows specifying the values when writing the file contents to memory but the values are actually ignored. This patch fixes that as well by erroring out when values are specified in such cases. llvm.org/pr49018.