Change Details

Because of https://llvm.org/PR50675, we can end up producing a PLT relocation referencing a symbol that's dropped from the dynamic symbol table, which in turn causes a crash at runtime. We ran into this again recently, resulting in crashes for our users. Rather than silently producing a binary that will crash at runtime, error out if we attempt to produce a GOT or PLT relocation against a symbol not in the dynamic symbol table.

Because of https://llvm.org/PR50675, we can end up producing a PLT relocation referencing a symbol that's dropped from the dynamic symbol table, which in turn causes a crash at runtime. We ran into this again recently, resulting in crashes for our users. A subsequent diff will fix that issue, but add an assert to catch it if it happens again.

Because of https://llvm.org/PR50675, we can end up producing a PLT relocation referencing a symbol that's dropped from the dynamic symbol table, which in turn causes a crash at runtime. We ran into this again recently, resulting in crashes for our users. Rather than silentlyA subsequent diff will fix producing a binary that will crash at runtimeissue, error out if we attempt to produce a GOT or PLT relocation against a symbol not in the dynamic symbol tablebut add an assert to catch it if it happens again.