Change Details

This patch makes template instantiations be already performed in the PCH instead of it being done in every single file that uses the PCH (but every single file will still do it as well in order to handle its own instantiations). I can see 20-30% build time saved with the few tests I've tried. The delaying of template instantiations until the PCH is used comes from 7f76d11dcc9196e1fc9d1308da9ed2330a6b06c2 , which doesn't really give any useful reasoning for it, except for extending a unittest, which however now passes even with the instantiation moved back into the PCH. It is still possible that an instantiation may need to be done only in the TU, but the patch should detect and handle that. I've built a complete debug build of LibreOffice with the patch and everything seems to work fine. The change itself is rather simple, but ~22 tests fail merely because this change reorders things differently than the tests expect, without any actual change.

Add -fpch-instantiate-templates which makes template instantiations be performed already in the PCH instead of it being done in every single file that uses the PCH (but every single file will still do it as well in order to handle its own instantiations). I can see 20-30% build time saved with the few tests I've tried. The change may reorder compiler output and also generated code, but should be generally safe and produce functionally identical code. There are some rare cases that do not compile with it, such as test/PCH/pch-instantiate-templates-forward-decl.cpp. If template instantiation bailed out instead of reporting the error, these instantiations could even be postponed, which would make them work.

This patchAdd -fpch-instantiate-templates which makes template instantiations be already performedperformed already in the PCH instead of it being done in every single file that uses the PCH (but every single file will still do it as well in order to handle its own instantiations). I can see 20-30% build time saved with the few tests I've tried. The delaying of template instantiations until the PCH is used comes from 7f76d11dcc9196e1fc9d1308da9ed2330a6b06c2 change may reorder compiler output and also generated code, which doesn't rebut should be generally givsafe any useful reasoning for it,d produce functionally identical code. except for extending a unittestThere are some rare cases that do not compile with it, which however now passes even with the instantiation moved back into the PCH. It is still possible that an instantiation may need to be done only in the TU,such as test/PCH/pch-instantiate-templates-forward-decl.cpp. but the patch should detect and handle that. I've built a complete debug build of LibreOffice with the patch and everything seems to work fine. The change itself is rather simpleIf template instantiation bailed out instead of reporting the error, but ~22 tests fail merely because this change reorders things differently than the tests expectthese instantiations could even be postponed, without any actual changewhich would make them work.