Change Details

As discussed in https://github.com/clangd/clangd/issues/1082: "Without all-scopes-completion, such nested symbols would indeed be unnecessary in the index, because the only way you could get them as a completion result is if you're invoking the completion in the nested scope (e.g. Foo::^), in which case result can be obtained from the AST." I tested this on the LLVM codebase and there was no significant increase in index size (less than 1MB). I think this makes sense if we look at the additional data that is stored in SymbolCollector::addDeclaration when IndexedForCodeCompletion is set: - Signature: Empty string for enum constants - SnippetSuffix: Empty - Documentation: Empty most of the time - ReturnType and Type: Same string for all enum constants within a enum, so only two additional strings per indexed enum

As discussed in https://github.com/clangd/clangd/issues/1082: "Without all-scopes-completion, such nested symbols would indeed be unnecessary in the index, because the only way you could get them as a completion result is if you're invoking the completion in the nested scope (e.g. Foo::^), in which case result can be obtained from the AST. All-scopes-completion breaks this assumption, so the decision needs to be reevaluated." I tested this on the LLVM codebase and there was no significant increase in index size (less than 1MB). I think this makes sense if we look at the additional data that is stored in SymbolCollector::addDeclaration when IndexedForCodeCompletion is set: - Signature: Empty string for enum constants - SnippetSuffix: Empty - Documentation: Empty most of the time - ReturnType and Type: Same string for all enum constants within a enum, so only two additional strings per indexed enum

As discussed in https://github.com/clangd/clangd/issues/1082: "Without all-scopes-completion, such nested symbols would indeed be unnecessary in the index, because the only way you could get them as a completion result is if you're invoking the completion in the nested scope (e.g. Foo::^), in which case result can be obtained from the AST. All-scopes-completion breaks this assumption, so the decision needs to be reevaluated." I tested this on the LLVM codebase and there was no significant increase in index size (less than 1MB). I think this makes sense if we look at the additional data that is stored in SymbolCollector::addDeclaration when IndexedForCodeCompletion is set: - Signature: Empty string for enum constants - SnippetSuffix: Empty - Documentation: Empty most of the time - ReturnType and Type: Same string for all enum constants within a enum, so only two additional strings per indexed enum