Page MenuHomePhabricator

deletedProject
ArchivedPublic

Details

Description

The core LLVM libraries and compiler infrastructure.

Recent Activity

Nov 7 2018

jyknight closed D4276: Added llvm.is.constant intrinsic.
Nov 7 2018, 7:26 AM · deleted

Nov 6 2018

efriedma accepted D4276: Added llvm.is.constant intrinsic.

LGTM

Nov 6 2018, 3:29 PM · deleted
jyknight added a comment to D4276: Added llvm.is.constant intrinsic.

The SCCP bug is already be exhibited by the tests in test/CodeGen/Generic/is-constant.ll which pass a struct.

I'd prefer a testcase that explicitly calls "opt -sccp", as opposed to implicitly relying on the fact that opt -O2 includes SCCP. (You can just add a small test to test/Transforms/SCCP/ipsccp-basic.ll .)

Nov 6 2018, 3:10 PM · deleted
jyknight updated the diff for D4276: Added llvm.is.constant intrinsic.

Added sccp testcase.

Nov 6 2018, 3:10 PM · deleted
george.burgess.iv added a comment to D4276: Added llvm.is.constant intrinsic.

It may make sense to iterate, as you say, but that can/should be a different patch.

Nov 6 2018, 2:07 PM · deleted
efriedma added a comment to D4276: Added llvm.is.constant intrinsic.

The SCCP bug is already be exhibited by the tests in test/CodeGen/Generic/is-constant.ll which pass a struct.

Nov 6 2018, 2:05 PM · deleted
jyknight added a comment to D4276: Added llvm.is.constant intrinsic.

Picking this back up again...

Nov 6 2018, 1:51 PM · deleted
jyknight updated the diff for D4276: Added llvm.is.constant intrinsic.

Rebased onto current head, no changes.

Nov 6 2018, 1:49 PM · deleted

Aug 28 2018

void added a comment to D4276: Added llvm.is.constant intrinsic.

What's the status of this patch? I'm running into a situation where evaluating __builtin_constant_p through inlining may be useful.

Aug 28 2018, 2:34 AM · deleted

Jun 18 2018

Bharathi added a comment to D4276: Added llvm.is.constant intrinsic.

This feature would be very useful to us and testing this patch against our code base gave us an interesting case where llvm.is.constant (used in a conditional) is lowered to false in CodeGenPrepare and the dead branch that arises out of this lowering does not get eliminated. The code that gets generated after CodeGenPrepare pass has "br i1 false .." with both true and false conditions preserved and this propagates further and remains the same in the final assembly code.

Jun 18 2018, 5:03 PM · deleted

Jun 3 2018

void added a comment to D4276: Added llvm.is.constant intrinsic.

Friendly ping. :-)

Jun 3 2018, 10:44 PM · deleted

Apr 25 2018

cmatthews removed a parent revision for D4276: Added llvm.is.constant intrinsic: D44013: [LNT] Make Run-Over-Run and Run-Over-Baseline changes an accordion..
Apr 25 2018, 4:45 PM · deleted
pookie777geturight added a parent revision for D4276: Added llvm.is.constant intrinsic: D44013: [LNT] Make Run-Over-Run and Run-Over-Baseline changes an accordion..
Apr 25 2018, 4:14 AM · deleted

Apr 20 2018

efriedma added a comment to D4276: Added llvm.is.constant intrinsic.

Needs a testcase for the SCCP fix. Otherwise LGTM.

Apr 20 2018, 12:22 PM · deleted

Apr 19 2018

void added a comment to D4276: Added llvm.is.constant intrinsic.

I have no more concerns with this patch.

Apr 19 2018, 6:36 PM · deleted
jyknight added inline comments to D4276: Added llvm.is.constant intrinsic.
Apr 19 2018, 6:30 PM · deleted

Apr 18 2018

void added a comment to D4276: Added llvm.is.constant intrinsic.

Friendly ping? :-)

Apr 18 2018, 11:33 AM · deleted

Apr 15 2018

void added inline comments to D4276: Added llvm.is.constant intrinsic.
Apr 15 2018, 3:11 AM · deleted

Apr 13 2018

jyknight added inline comments to D4276: Added llvm.is.constant intrinsic.
Apr 13 2018, 5:43 PM · deleted
void added inline comments to D4276: Added llvm.is.constant intrinsic.
Apr 13 2018, 4:25 PM · deleted
jyknight added inline comments to D4276: Added llvm.is.constant intrinsic.
Apr 13 2018, 3:18 PM · deleted
jyknight updated the diff for D4276: Added llvm.is.constant intrinsic.

Ran clang-format.
Expanded on docs.

Apr 13 2018, 3:18 PM · deleted
void added inline comments to D4276: Added llvm.is.constant intrinsic.
Apr 13 2018, 2:29 PM · deleted
efriedma added a comment to D4276: Added llvm.is.constant intrinsic.

I guess lowering llvm.objectsize and llvm.is.constant at the same time makes sense; okay. They should probably both be lowered earlier, though.

Apr 13 2018, 12:54 PM · deleted
jyknight added a comment to D4276: Added llvm.is.constant intrinsic.

It seems like you're waiting to fold llvm.is.constant until really late in the optimization pipeline; we probably want to fold it sometime in the "middle", so we get better optimization. Maybe just after function simplification passes; at that point, we're unlikely to get any more useful information about whether the argument is constant, and we want to simplify the code as much as possible before we run transforms like loop vectorization.

Apr 13 2018, 12:43 PM · deleted
efriedma added a comment to D4276: Added llvm.is.constant intrinsic.

It seems like you're waiting to fold llvm.is.constant until really late in the optimization pipeline; we probably want to fold it sometime in the "middle", so we get better optimization. Maybe just after function simplification passes; at that point, we're unlikely to get any more useful information about whether the argument is constant, and we want to simplify the code as much as possible before we run transforms like loop vectorization.

Apr 13 2018, 12:16 PM · deleted
jyknight updated the summary of D4276: Added llvm.is.constant intrinsic.
Apr 13 2018, 10:15 AM · deleted
jyknight updated the diff for D4276: Added llvm.is.constant intrinsic.

Rewrote patch significantly.

Apr 13 2018, 10:14 AM · deleted
jyknight commandeered D4276: Added llvm.is.constant intrinsic.

Taking this over.

Apr 13 2018, 10:02 AM · deleted

Mar 15 2018

espindola edited reviewers for D4727: Fixed the getting of names and look-up entries of DLL imports., added: espindola; removed: rafael.
Mar 15 2018, 11:06 AM · deleted

Jul 6 2017

aemerson abandoned D4207: Fix crash in LICM due to unreachable uses after LCSSA.
Jul 6 2017, 10:55 AM · deleted
aemerson updated subscribers of D4207: Fix crash in LICM due to unreachable uses after LCSSA.
Jul 6 2017, 10:54 AM · deleted

Feb 3 2016

george.burgess.iv abandoned D4551: LLVM CFL Alias Analysis -- Algorithm.
Feb 3 2016, 11:50 AM · deleted
george.burgess.iv commandeered D4551: LLVM CFL Alias Analysis -- Algorithm.

Commandeering to abandon; this went in a long time ago as part of D5106.

Feb 3 2016, 11:50 AM · deleted
george.burgess.iv abandoned D4550: LLVM CFL Alias Analysis -- Supporting Data Structures.
Feb 3 2016, 11:50 AM · deleted
george.burgess.iv commandeered D4550: LLVM CFL Alias Analysis -- Supporting Data Structures.

Commandeering to abandon; this went in a long time ago as part of D5106.

Feb 3 2016, 11:50 AM · deleted

Dec 30 2015

iid_iunknown abandoned D4928: Bug 14070 - Deeply nested struct types cause opt run time to explode.
Dec 30 2015, 1:55 PM · deleted

Oct 22 2015

m.ostapenko closed D4692: Test failures in GCC ASan testsuite on ARM Linux due to FP format mismatch between libsanitizer and GCC..
Oct 22 2015, 5:28 AM · deleted

Jul 3 2015

klimek closed D4283: Adding 4 ASTMatchers: typedefDecl, isInMainFile, isInSystemFile, isInFileMatchingName.
Jul 3 2015, 7:04 AM · deleted

May 29 2015

EricWF resigned from D4341: [libcxx] Correct SFINAE version of is_convertible to match spec and avoid triggering unnecessary compiler diagnostics.

This review has been inactive for a long time and this bug has already been fixed

May 29 2015, 4:05 PM · deleted

May 27 2015

mclow.lists closed D4340: [libcxx] Take advantage of gcc4.7 frontend support in type_traits.
May 27 2015, 6:38 PM · deleted

Mar 29 2015

chandlerc resigned from D4928: Bug 14070 - Deeply nested struct types cause opt run time to explode.

I suspect Nick is a better reviewer here than I am... The structure of this code makes zero sense to me and I suspect it should be refactored more heavily than just this point fix.... But he would know better.

Mar 29 2015, 1:07 PM · deleted
chandlerc removed a reviewer for D4551: LLVM CFL Alias Analysis -- Algorithm: chandlerc.
Mar 29 2015, 12:52 PM · deleted
chandlerc removed a reviewer for D4550: LLVM CFL Alias Analysis -- Supporting Data Structures: chandlerc.
Mar 29 2015, 12:51 PM · deleted
chandlerc removed a reviewer for D4207: Fix crash in LICM due to unreachable uses after LCSSA: chandlerc.
Mar 29 2015, 12:44 PM · deleted

Mar 13 2015

rengolin closed D4607: Fix flags for compiling examples/Kaleidoscope/MCJIT.
Mar 13 2015, 3:17 AM · deleted
rengolin resigned from D4276: Added llvm.is.constant intrinsic.
Mar 13 2015, 3:13 AM · deleted

Mar 10 2015

rengolin added a comment to D4607: Fix flags for compiling examples/Kaleidoscope/MCJIT.

Any progress in this?

Mar 10 2015, 6:07 AM · deleted
rengolin added a comment to D4276: Added llvm.is.constant intrinsic.

Any progress in this? If not, can we close this review?

Mar 10 2015, 4:39 AM · deleted

Dec 17 2014

jfb closed D4377: Random Number Generator Refactoring (removing from Module) by committing rL224444: Random Number Generator Refactoring (removing from Module).
Dec 17 2014, 10:13 AM · deleted