HomePhabricator

Changed to use cmake arguments to specify C and C++ compilers.
Concern Raised94e652786cb7

Authored by gkistanova on Sep 17 2020, 7:06 PM.

Description

Changed to use cmake arguments to specify C and C++ compilers.

Details

Auditors
maxim-kuvyrkov
Committed
gkistanovaSep 17 2020, 7:06 PM
Parents
rZORG3b3349e94a30: clang-x86-ninja-win10: removed DIA flag, added LIBZ flag
Branches
Unknown
Tags
Unknown

Event Timeline

maxim-kuvyrkov raised a concern with this commit.Fri, Oct 9, 8:36 AM
maxim-kuvyrkov added a subscriber: maxim-kuvyrkov.

@gkistanova
Hi Galina,

This patch broke Windows on Arm 2-stage bot due to the exact reason described in the comment. See http://lab.llvm.org:8011/#/builders/120/builds/3/steps/8/logs/stdio .
Quoting of windows-style paths gets broken somewhere between buildbot and cmake. Passing the paths via environment variables seems to workaround the problem.

This commit now has outstanding concerns.Fri, Oct 9, 8:36 AM

Hello Maxim,

Forward slash path separators should work there. I'll prepare the patch
later.

In the meantime, could you edit your buildbot.tac file and specify the
basedir with forward slash path separators, please?
That should be a workaround for now.

Thanks

Galina

I've updated buildbot.tac. Thanks, Galina.