HomePhabricator

[FileCheck] Introduce substitution subclasses
94aa1e382019Unpublished

Authored by thopre on May 22 2019, 5:10 PM.

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.
This commit no longer exists in the repository. It may have been part of a branch which was deleted.This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

[FileCheck] Introduce substitution subclasses

Summary:
With now a clear distinction between string and numeric substitutions,
this patch introduces separate classes to represent them with a parent
class implementing the common interface. Diagnostics in
printSubstitutions() are also adapted to not require knowing which
substitution is being looked at since it does not hinder clarity and
makes the implementation simpler.

Reviewers: jhenderson, jdenny, probinson, arichardson

Subscribers: llvm-commits, probinson, arichardson, hiraditya

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D62241

llvm-svn: 361446

Details

Committed
sidorovdMay 24 2019, 5:44 AM
Differential Revision
D62241: [FileCheck] Introduce substitution subclasses

Commit No Longer Exists

This commit no longer exists in the repository.