HomePhabricator

[ForwardOpTree] Use less computationally expensive method to compute def-to…

Description

[ForwardOpTree] Use less computationally expensive method to compute def-to-target map. NFCI.

When forwarding a LoadInst to another statement, a map that translates
their domain is needed. Before this patch, is was computed by appending
the def-to-use map to the def-to-target of the operand tree's target.

This patch lets the new method getDefToTarget do this. This is
computationally less expensive due to:

  • Caching of the result such that it can be used for multiple operands tree to the same target.
  • The map is only computed when there is a LoadInst that needs it.
  • It is only computed for the statement requiring the translator map, instead of having an intermediate result for every edge in the operand tree.

The downside is that this scheme cannot handle forwarding from a
previous loop iteration (which would require the entire path from
statement to target). Since ForwardOpTree currently does not support
forwarding across loop iterations (SCEV expressions would need to be
transformed), this was not needed anyway.

Differential Revision: https://reviews.llvm.org/D47385

Details

Committed
MeinersburMay 29 2018, 8:19 AM
Differential Revision
D47385: [Polly][ForwardOpTree] Use less computationally expensive method to compute def-to-target map. NFCI.
Branches
Unknown
Tags
Unknown