HomePhabricator

Use value semantics for list of ScopStmt(s) instead of std::owningptr

Description

Use value semantics for list of ScopStmt(s) instead of std::owningptr

David Blaike suggested this as an alternative to the use of owningptr(s) for our
memory management, as value semantics allow to avoid the additional interface
complexity caused by owningptr while still providing similar memory consistency
guarantees. We could also have used a std::vector, but the use of std::vector
would yield possibly changing pointers which currently causes problems as for
example the memory accesses carry pointers to their parent statements. Such
pointers should not change.

Reviewer: jblaikie, jdoerfert

Differential Revision: http://reviews.llvm.org/D10041

Details

Committed
grosserMay 26 2015, 10:16 PM
Differential Revision
D10041: Use value semantics for list of ScopStmt(s) instead of std::owningptr
Branches
Unknown
Tags
Unknown