HomePhabricator

[CMake] Always build debugserver on Darwin and allow tests to use the system's…

Description

[CMake] Always build debugserver on Darwin and allow tests to use the system's one

Summary:
We can always build debugserver, but we can't always sign it to be useable for testing. LLDB_USE_SYSTEM_DEBUGSERVER should only tell whether or not the system debugserver should be used for testing.
The old behavior complicated the logic around debugserver a lot. The new logic sorts out most of it.

Please note that this patch is in early stage and needs some more testing. It should not affect platfroms other than Darwin. It builds on Davide's approach to validate the code-signing identity at configuration time.

What do you think?

Reviewers: xiaobai, JDevlieghere, davide, compnerd, friss, labath, mgorny, jasonmolenda

Reviewed By: JDevlieghere

Subscribers: lldb-commits, #lldb

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D64806

Details

Committed
stefan.graenitzJul 18 2019, 6:30 AM
Reviewer
JDevlieghere
Differential Revision
D64806: [CMake] Always build debugserver on Darwin and allow tests to use the system's one
Branches
Unknown
Tags
Unknown