HomePhabricator

[Utility] Fix ArchSpec.MergeFrom to correctly merge environments

Description

[Utility] Fix ArchSpec.MergeFrom to correctly merge environments

Summary:
This behavior was originally added in rL252264 (git commit 76a7f365da)
in order to be extra careful with handling platforms like watchos and tvos.
However, as far as triples go, those two (and others) are treated as OSes and
not environments, so that should not really apply here.

Additionally, this behavior is incorrect and can lead to incorrect ArchSpecs.
Because android is specified as an environment and not an OS, not propogating
the environment can lead to modules and targets being misidentified.

Differential Revision: https://reviews.llvm.org/D58664

Details

Committed
xiaobaiFeb 26 2019, 4:47 PM
Differential Revision
D58664: [Utility] Fix ArchSpec.MergeFrom to correctly merge environments
Branches
Unknown
Tags
Unknown