HomePhabricator

lldb-test ir-memory-map: Use IntervalMap::contains

Description

lldb-test ir-memory-map: Use IntervalMap::contains

Summary:
Simplify the code by using the contains implementation in IntervalMap.

There is a slight change of behavior here: We now treat an allocation of
size 0, as if it was size 1. This guarantees that the returned addresses
will be unique, whereas previously we would allow the allocation
function to return the same zero-sized region multiple times, as long as
it is not null, and not in the middle of an existing interval (but the
situation when we were placing an larger interval over a zero-sized one
was not detected).

I think this behavior makes more sense, as that is pretty much the same
guarantee as offered by malloc (except that is permitted to also return
nullptr).

Reviewers: vsk

Subscribers: lldb-commits

Differential Revision: https://reviews.llvm.org/D55761

Details

Committed
labathDec 27 2018, 1:32 AM
Differential Revision
D55761: lldb-test ir-memory-map: Use IntervalMap::contains
Parents
rLLDB350086: DWARF: Fix a bug in array size computation
Branches
Unknown
Tags
Unknown