HomePhabricator

ObjectFileMachO: split CreateSections mega-function into more manageable chunks

Description

ObjectFileMachO: split CreateSections mega-function into more manageable chunks

Summary:
In an effort to understand the function's operation, I've split it into logical
pieces. Parsing of a single segment is moved to a separate function (and the
parsing state that is carried from one segment to another is explicitly
captured in the SegmentParsingContext object). I've also extracted some pieces
of code which were already standalone (validation of the segment load command,
determining the section type, determining segment permissions) into
separate functions.

Parsing of a single section within the segment should probably also be a
separate function, but I've left that for a separate patch.

This patch is intended to be NFC.

Reviewers: clayborg, davide

Subscribers: lldb-commits

Differential Revision: https://reviews.llvm.org/D44074

Details

Committed
labathMar 6 2018, 5:53 AM
Differential Revision
D44074: ObjectFileMachO: split CreateSections mega-function into more manageable chunks
Branches
Unknown
Tags
Unknown