HomePhabricator

[lld][mach-o] Avoid segfaulting when handling an empty section list.

Description

[lld][mach-o] Avoid segfaulting when handling an empty section list.

Summary:
The following patch avoids segfaulting if the section list is empty when writing a mach-o MH_OBJECT. I ran into this case from a more complicated example trying to dead_strip while using '-r' in lld.

I'm not sure if having empty sections is a legal mach-o, but it does seem that other llvm-binutils tools can ingest such a boring object with out issue. Would it be better to emit an error, emit a warning, or do nothing? It seems that adding a warning diagnostic might be helpful to users, as I did not expect to have a section-less object when the linker was done.

Reviewers: kledzik, ruiu

Subscribers: llvm-commits, jrm

Tags: lld, #llvm

Differential Revision: https://reviews.llvm.org/D67735

Details

Committed
mattdSep 26 2019, 10:03 AM
Differential Revision
D67735: [lld][mach-o] Avoid segfaulting when handling an empty section list.
Branches
Unknown
Tags
Unknown