HomePhabricator

Reapply r375051: [support] GlobPattern: add support for `\` and `[!...]`, and…

Description

Reapply r375051: [support] GlobPattern: add support for \ and [!...], and allow ] in more places

Reland r375051 (reverted in r375052) after fixing lld tests on Windows in r375126 and r375131.

Original description: Update GlobPattern in libSupport to handle a few more cases. It does not fully match the fnmatch used by GNU objcopy since named character classes (e.g. [[:digit:]]) are not supported, but this should support most existing use cases (mostly just * is what's used anyway).

This will be used to implement the --wildcard flag in llvm-objcopy to be more compatible with GNU objcopy.

This is split off of D66613 to land the libSupport changes separately. The llvm-objcopy part will land soon.

Reviewers: jhenderson, MaskRay, evgeny777, espindola, alexshap

Reviewed By: MaskRay

Subscribers: nickdesaulniers, emaste, arichardson, hiraditya, jakehehrlich, abrachet, seiya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D66613

Details

Committed
rupprechtOct 17 2019, 11:09 AM
Reviewer
MaskRay
Differential Revision
D66613: [support][llvm-objcopy] Add support for shell wildcards
Parents
rL375148: NFC: Fix variable only used in asserts by propagating the value.
Branches
Unknown
Tags
Unknown