HomePhabricator

[lit] Clean up internal diff's encoding handling

Description

[lit] Clean up internal diff's encoding handling

As suggested by rnk at D67643#1673043, instead of reading files
multiple times until an appropriate encoding is found, read them once
as binary, and then try to decode what was read.

For Python >= 3.5, don't fail when attempting to decode the
diff_bytes output in order to print it.

Avoid failures for Python 2.7 used on some Windows bots by
transforming diff output with lit.util.to_string before writing it
to stdout.

Finally, add some tests for encoding handling.

Reviewed By: rnk

Differential Revision: https://reviews.llvm.org/D68664

Details

Committed
jdennyOct 16 2019, 10:21 AM
Reviewer
rnk
Differential Revision
D68664: [lit] Clean up internal diff's encoding handling
Parents
rL375017: [OPENMP]Use different addresses for zeroed thread_id/bound_id.
Branches
Unknown
Tags
Unknown