HomePhabricator

[Analysis] Allow -scalar-evolution-max-iterations more than once

Description

[Analysis] Allow -scalar-evolution-max-iterations more than once

At present, -scalar-evolution-max-iterations is a cl::Optional
option, which means it demands to be passed exactly zero or one times.
Our build system makes it pretty tricky to guarantee this. We often
accidentally pass the flag more than once (but always with the same
value) which results in an error, after which compilation fails:

clang (LLVM option parsing): for the -scalar-evolution-max-iterations option: may only occur zero or one times!

It seems reasonable to allow -scalar-evolution-max-iterations to be
passed more than once. Quoting the documentation:

The cl::ZeroOrMore modifier ... indicates that your program will allow the option to be specified zero or more times.
...
If an option is specified multiple times for an option of the cl::opt class, only the last value will be retained.

Original patch by: Enrico Bern Hardy Tanuwidjaja <etanuwid@fb.com>

Differential Revision: https://reviews.llvm.org/D67512

Details

Committed
smeenaiSep 19 2019, 11:21 AM
Differential Revision
D67512: [Analysis] Allow -scalar-evolution-max-iterations more than once
Parents
rL372345: [NFC][PowerPC] Fast-isel VSX support test
Branches
Unknown
Tags
Unknown