HomePhabricator

[PGO] Change hardcoded thresholds for cold/inlinehint to use summary

Description

[PGO] Change hardcoded thresholds for cold/inlinehint to use summary

Summary:
The PGO counter reading will add cold and inlinehint (hot) attributes
to functions that are very cold or hot. This was using hardcoded
thresholds, instead of the profile summary cutoffs which are used in
other hot/cold detection and are more dynamic and adaptable. Switch
to using the summary-based cold/hot detection.

The hardcoded limits were causing some code that had a medium level of
hotness (per the summary) to be incorrectly marked with a cold
attribute, blocking inlining.

Reviewers: davidxl

Subscribers: llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D67673

Details

Committed
tejohnsonSep 17 2019, 4:12 PM
Differential Revision
D67673: [PGO] Change hardcoded thresholds for cold/inlinehint to use summary
Parents
rL372188: [CodeGen] Handle outlining of CopyStmts.
Branches
Unknown
Tags
Unknown