HomePhabricator

[analyzer] Add a checker option to detect nested dead stores

Description

[analyzer] Add a checker option to detect nested dead stores

Enables the users to specify an optional flag which would warn for more dead
stores.
Previously it ignored if the dead store happened e.g. in an if condition.

if ((X = generate())) { // dead store to X
}

This patch introduces the WarnForDeadNestedAssignments option to the checker,
which is false by default - so this change would not affect any previous
users.
I have updated the code, tests and the docs as well. If I missed something, tell
me.

I also ran the analysis on Clang which generated 14 more reports compared to the
unmodified version. All of them seemed reasonable for me.

Related previous patches:
rGf224820b45c6847b91071da8d7ade59f373b96f3

Reviewers: NoQ, krememek, Szelethus, baloghadamsoftware

Reviewed By: Szelethus

Patch by Bal√°zs Benics!

Differential Revision: https://reviews.llvm.org/D66733

Details

Committed
SzelethusTue, Sep 3, 8:22 AM
Reviewer
Szelethus
Differential Revision
D66733: [analyzer] Add a checker option to detect nested dead stores
Parents
rL370766: Requeset commit access for josepht
Branches
Unknown
Tags
Unknown