HomePhabricator

[TSan] #include header instead of forward declaring interceptees

Description

[TSan] #include header instead of forward declaring interceptees

Details

Committed
ylnAug 21 2019, 4:42 PM
Parents
rL369600: [Object] Add tapi files to object
Branches
Unknown
Tags
Unknown

Event Timeline

nickdesaulniers added inline comments.
/compiler-rt/trunk/lib/tsan/rtl/tsan_interceptors_mac.cpp
26

Is os/lock.h available in 10.9 SDK? I believe this change has regressed our Android SDK build for MacOS.

yln marked an inline comment as done.Oct 16 2019, 5:16 PM
yln added inline comments.
/compiler-rt/trunk/lib/tsan/rtl/tsan_interceptors_mac.cpp
26

Hi Nick,

os_unfair_lock_lock was introduced in macOS 10.12. This means that you have to upgrade your builder to use at least SDK 10.12. However, I am not aware of any reason not to use the most recent SDK (10.15) for building. Let me know if you have any issues with this.

The lowest supported version for running is set via the "deployment target". AFAIR, this is set to 10.9 for compiler-rt.