HomePhabricator

[sanitizer_common] Replace forkpty with posix_spawn on Darwin

Description

[sanitizer_common] Replace forkpty with posix_spawn on Darwin

On Darwin, we currently use forkpty to communicate with the "atos"
symbolizer. There are several problems that fork[pty] has, e.g. that
after fork, interceptors are still active and this sometimes causes
crashes or hangs. This is especially problematic for TSan, which uses
interceptors for OS-provided locks and mutexes, and even Libc functions
use those.

This patch replaces forkpty with posix_spawn on Darwin. Since
posix_spawn doesn't fork (at least on Darwin), the interceptors are not
a problem. Another benefit is that we'll handle post-fork failures (e.g.
sandbox disallows "exec") gracefully now.

Related revisions and previous attempts that were blocked by or had to
be revered due to test failures:
https://reviews.llvm.org/D48451
https://reviews.llvm.org/D40032

Reviewed By: kubamracek

Differential Revision: https://reviews.llvm.org/D65253

Details

Committed
ylnAug 14 2019, 5:18 PM
Reviewer
kubamracek
Differential Revision
D65253: [sanitizer_common] Replace forkpty with posix_spawn on Darwin
Parents
rL368946: [compiler-rt] Migrate llvm::make_unique to std::make_unique
Branches
Unknown
Tags
Unknown