HomePhabricator

Reland: [Remarks] Support parsing remark metadata in the YAML remark parser

Description

Reland: [Remarks] Support parsing remark metadata in the YAML remark parser

This adds support to the yaml remark parser to be able to parse remarks
directly from the metadata.

This supports parsing separate metadata and following the external file
with the associated metadata, and also a standalone file containing
metadata + remarks all together.

Original llvm-svn: 367148
Revert llvm-svn: 367151

This has a fix for gcc builds.

Details

Committed
thegamegJul 26 2019, 2:02 PM
Parents
rL367154: [JumpThreading] Stop searching predecessor when the current bb is in a
Branches
Unknown
Tags
Unknown

Event Timeline

rnk added a subscriber: rnk.Jul 26 2019, 3:01 PM
rnk added inline comments.
/llvm/trunk/unittests/Remarks/YAMLRemarksParsingTest.cpp
706

These error messages are platform dependent. On Windows, it happens to come back lower case:
http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/9077

[ RUN      ] YAMLRemarks.ParsingBadMeta
C:\b\slave\clang-x64-windows-msvc\build\llvm.src\unittests\Remarks\YAMLRemarksParsingTest.cpp(74): error:       Expected: Stream.str()
      Which is: "no such file or directory"
To be equal to: Error
      Which is: "No such file or directory"
[  FAILED  ] YAMLRemarks.ParsingBadMeta (1 ms)
rnk added inline comments.Jul 26 2019, 3:11 PM
/llvm/trunk/unittests/Remarks/YAMLRemarksParsingTest.cpp
706

I applied a workaround in rL367159, but you might consider improving on it.

thegameg marked an inline comment as done.Jul 26 2019, 3:12 PM
thegameg added inline comments.
/llvm/trunk/unittests/Remarks/YAMLRemarksParsingTest.cpp
706

Thanks! I'll put a fix up.