HomePhabricator

[ELF] Update test case due to llvm r365618
Audit RequiredrL365619

Description

[ELF] Update test case due to llvm r365618

Details

Auditors
Bigcheese
Committed
NikolaPricaJul 10 2019, 4:19 AM
Parents
rL365618: [ELF] Loose a condition for relocation with a symbol
Branches
Unknown
Tags
Unknown

Event Timeline

This commit now requires audit.Jul 10 2019, 4:20 AM
MaskRay added inline comments.
/lld/trunk/test/ELF/mips-got-string.s
13

llvm-readelf and llvm-readobj are usually better than llvm-objdump because llvm-objdump retains less ELF information and its output is considered weird by many people.

NikolaPrica marked an inline comment as done.Jul 11 2019, 8:18 AM
NikolaPrica added inline comments.
/lld/trunk/test/ELF/mips-got-string.s
13

I agree. Since there is no longer this symbol .str do you think we should remove check for it and just second check? Second check is relocation address of R_MIPS_GOT16(%got($.str)($gp)) and first one is for R_MIPS_LO16 (addiu $a0, $t9, %lo($.str)). I did it like this because i didn't want to lose check for this second relocation but I'm not quite sure how can I verify it not when there is no .str?

I simplify the test at rL365834. Hope this help.