HomePhabricator

[clang] DirectoryWatcher

Description

[clang] DirectoryWatcher

Asynchronously monitors specified directory for changes and passes notifications to provided callback.

Dependency for index-while-building.

Differential Revision: https://reviews.llvm.org/D58418

Details

Committed
jkorousJul 9 2019, 3:44 PM
Differential Revision
D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher
Parents
rL365573: [AMDGPU] gfx908 v_pk_fmac_f16 support
Branches
Unknown
Tags
Unknown

Event Timeline

Hi Jan,

I'm not sure how, but I think this commit broke building with ninja at least on some platforms.

e.g. http://lab.llvm.org:8011/builders/clang-cmake-armv8-lnt/builds/10583

I saw the same error locally and it bisected to this revision.
The line it didn't like in generated build.ninja began: LINK_LIBRARIES = -Wl,-rpath,"\$$ORIGIN/../lib" lib/libLLVMCore.a and appears to be for the clang_shared lib.

The equivalent line in a good build.ninja looks similar though... I can't dig into it right now, it's pretty late.