HomePhabricator

[lld] Use -o /dev/null in test when output is not needed.
Audit RequiredrL364999

Description

[lld] Use -o /dev/null in test when output is not needed.

Feedback nit from rL364998

Details

Auditors
Bigcheese
Committed
sbcJul 2 2019, 7:41 PM
Parents
rL364998: [ELF] Error on archive with missing index
Branches
Unknown
Tags
Unknown

Event Timeline

This commit now requires audit.Jul 2 2019, 7:41 PM

I'm not sure this is correct.

/lld/trunk/test/ELF/archive-no-index.s
4

The output file %t.archive.o appears to be used below on line 6, so outputting to /dev/null here causes the test to fail, I think.

8

As far as I can tell the review comments for https://reviews.llvm.org/D63781 refer to the -o out.wasm on this line.

MaskRay added inline comments.
/lld/trunk/test/ELF/archive-no-index.s
4

This is correct, but I would no bother updating this single case. I had a change to update most cases luke this, I was just not sure if I should update them all in batch.

modocache added a subscriber: ruiu.Jul 2 2019, 10:55 PM

Thanks to @ruiu for fixing this in rL365001 :)

ruiu added a comment.Jul 2 2019, 11:06 PM

Thanks to @ruiu for fixing this in rL365001 :)

Feel free to revert a change without pre-commit review if it is obvious that a change broke a build.