HomePhabricator

Fix breakage introduced by D60974

Description

Fix breakage introduced by D60974

D60974 added tests which incorrectly assume that llvm-readelf is available. This is a bad assumption, it should instead declare the dependency explicitly in the tests.

Details

Committed
jfbJul 1 2019, 2:57 PM
Parents
rL364854: Add dev mtg link
Branches
Unknown
Tags
Unknown

Event Timeline

jfb added a subscriber: plotfi.Jul 1 2019, 3:05 PM

FWIW I don't think this is the right fix, and we should revert it once @plotfi fixes the tests from D60974.

plotfi added a comment.Jul 1 2019, 3:08 PM

Thank you @jfb !
I missed this, and hadn't noticed any bots fail on it.

Much Appreciated.

PL

plotfi added a subscriber: compnerd.Jul 1 2019, 3:09 PM

FWIW I don't think this is the right fix, and we should revert it once @plotfi fixes the tests from D60974.

This I do believe is the right fix. I replied you my thoughts in D60974.

@compnerd What do you think?

PL