[TSan] Attempt to fix linker error for Linux on AArch64
Introduced in 5be69ebe121d5b6ea284c3dc6d1cd5098c94f353.
We are still seeing liner errors in the AArch64 build bots (http://lab.llvm.org:8011/builders/clang-cmake-aarch64-full/builds/7487/steps/ninja%20check%202/logs/stdio), are you looking into this? If there's not a quick, obvious fix, it would be better to revert the original commit to get the bots back to green.
Thanks for pointing this out to me; and apologies for the churn. I pushed a revert/attempted fix.
I want to fix this instead of a blanket revert, because it allows me to ensure that the code that is going to replace the assembly produces the same result on architectures I cannot test directly.
InitializeGuardPtr(); InitializeLongjmpXorKey(); CHECK_EQ(longjmp_xor_key, _tsan_pointer_chk_guard);
Thanks, that's fixed the link errors, but we are now seeing some failures in TSan tests (http://lab.llvm.org:8011/builders/clang-cmake-aarch64-lld/builds/6874, http://lab.llvm.org:8011/builders/clang-cmake-aarch64-lld/builds/6874/steps/ninja%20check%201/logs/FAIL%3A%20ThreadSanitizer-aarch64%3A%3A%20fiber_longjmp.cc). Could these be related to one of your patches?