HomePhabricator

Re-commit r357452 (take 3): "SimplifyCFG SinkCommonCodeFromPredecessors: Also…

Description

Re-commit r357452 (take 3): "SimplifyCFG SinkCommonCodeFromPredecessors: Also sink function calls without used results (PR41259)"

Third time's the charm.

This was reverted in r363220 due to being suspected of an internal benchmark
regression and a test failure, none of which turned out to be caused by this.

Details

Committed
hansJun 17 2019, 12:47 AM
Parents
rL363528: DWARF: Avoid storing DIERefs in long-lived containers
Branches
Unknown
Tags
Unknown

Event Timeline

dim added a subscriber: dim.Sep 10 2019, 12:34 PM

Third time's the charm.

Unfortunately there may have to be a fourth time, since this commit causes https://bugs.llvm.org/show_bug.cgi?id=43269 :-)

hans added a comment.Sep 13 2019, 12:27 AM

Third time's the charm.

Unfortunately there may have to be a fourth time, since this commit causes https://bugs.llvm.org/show_bug.cgi?id=43269 :-)

Thanks for letting me know!