HomePhabricator

adding more fmf propagation for selects plus tests

Description

adding more fmf propagation for selects plus tests

Event Timeline

Hey, so I'm seeing these tests starting to fail with llc errors. The output looks like this (after going through the output-scanning layer):

<stdin>:1:1: note: scanning from here
llc: Unknown command line argument '-debug-only=isel'. Try: 'llc --help'
^
<stdin>:2:2: note: possible intended match here
llc: Did you mean ' --debug-pass=isel'?
^

Am I missing something?

Hey, so I'm seeing these tests starting to fail with llc errors. The output looks like this (after going through the output-scanning layer):

<stdin>:1:1: note: scanning from here
llc: Unknown command line argument '-debug-only=isel'. Try: 'llc --help'
^
<stdin>:2:2: note: possible intended match here
llc: Did you mean ' --debug-pass=isel'?

^

Am I missing something?

These tests that contain -debug-only=isel need ; REQUIRES: asserts (the code is only compiled in -DLLVM_ENABLE_ASSERTIONS=on builds), but I don't know if we want many tests that only run on -DLLVM_ENABLE_ASSERTIONS=on builds.

I was just about to change the test to assembler check test, not using the assert path...

Sorry @mcberg2017, I reverted rL363474 in rL363482, because it caused failures on -DLLVM_ENABLE_ASSERTIONS=off builds.

Among 3672 tests under test/CodeGen/X86, only 63 have REQUIRES: asserts (they are skipped by default -DCMAKE_BUILD_TYPE=Release builds). I am not sure whether we should add REQUIRES: asserts to more tests.