HomePhabricator

Stop undef fragments from closing non-overlapping fragments

Description

Stop undef fragments from closing non-overlapping fragments

Summary:
When DwarfDebug::buildLocationList() encountered an undef debug value,
it would truncate all open values, regardless if they were overlapping or
not. This patch fixes so that it only does that for overlapping fragments.

This change unearthed a bug that I had introduced in D57511,
which I have fixed in this patch. The code in DebugHandlerBase that
changes labels for parameter debug values could break DwarfDebug's
assumption that the labels for the entries in the debug value history
are monotonically increasing. Before this patch, that bug could result
in location list entries whose ending address was lower than the
beginning address, and with the changes for undef debug values that this
patch introduces it could trigger an assertion, due to attempting to
emit location list entries with empty ranges. A reproducer for the bug
is added in param-reg-const-mix.mir.

Reviewers: aprantl, jmorse, probinson

Reviewed By: aprantl

Subscribers: javed.absar, llvm-commits

Tags: debug-info, #llvm

Differential Revision: https://reviews.llvm.org/D62379

Details

Committed
dstenbMay 28 2019, 6:23 AM
Reviewer
aprantl
Differential Revision
D62379: [DebugInfo] Stop undef fragments from closing non-overlapping fragments
Parents
rL361819: MIR: Fix printer crashing on dead CSR frame indexes
Branches
Unknown
Tags
Unknown